Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a real family tree view #67

Open
mrysav opened this issue Sep 23, 2021 · 0 comments
Open

Add a real family tree view #67

mrysav opened this issue Sep 23, 2021 · 0 comments
Labels
javascript Pull requests that update Javascript code large-sized! ruby Pull requests that update Ruby code

Comments

@mrysav
Copy link
Owner

mrysav commented Sep 23, 2021

The current "family tree" view leaves (ha!) a lot to be desired.

family_tree

It's not actually a tree at all - just a poor use of responsive layouts.

I don't know how you can do it, and I'm not smart or frontend-savvy enough to know where to start.

Acceptance Criteria

1. Replace the view in views/people/show_family.haml with a real family tree

This can be rendered server-side or client-side, in Ruby or in Javascript.

If you need additional API endpoints added, or any changes to the underlying Ruby controller code, that's totally cool, but please make sure to discuss the changes first and add a test for it.

At a minimum, this tree should display (as a tree):

  1. The target person (ie. the person whose page you're on)
  2. Their parents
  3. Their parents' parents (ie. their grandparents)
  4. Links to each person displayed

Displaying the target person's siblings and children is highly desirable, but not required.

@mrysav mrysav added hacktoberfest javascript Pull requests that update Javascript code large-sized! ruby Pull requests that update Ruby code labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code large-sized! ruby Pull requests that update Ruby code
Projects
None yet
Development

No branches or pull requests

1 participant