Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable launching C++ and Python binaries on Linux #124

Merged
merged 4 commits into from
Sep 17, 2019

Conversation

kejxu
Copy link

@kejxu kejxu commented Sep 16, 2019

C++ binary and Python scripts are all executable on Linux, to distinguish between these 2, need to check shebang line for the Python script. In this change, we read the first line of the executable and check if it is a shebang pointing to Python, and launch Python/C++ debug sessions based on that check.

also in this change: pass down ROS node names to debug sessions for better readability

@kejxu kejxu requested a review from a team September 16, 2019 21:51
Copy link

@seanyen seanyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seanyen seanyen merged commit dcb4d4b into ms-iot:master Sep 17, 2019
@kejxu kejxu deleted the linux_launch branch September 17, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants