New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Something very odd #133

Closed

KlausVigo opened this issue May 10, 2022 · 1 comment

KlausVigo commented May 10, 2022

What is going on here? This seems very odd!

> library(TreeSearch)
> library(phangorn)
> data(yeast)
> set.seed(42)
> tree <- rtree(8, tip.label=names(yeast))
> tree2 <- root(tree, 2, resolve.root = TRUE)
> TreeLength(tree, yeast)
[1] 156321
> TreeLength(tree2, yeast)
[1] 156321
> TreeLength(c(tree, tree2), yeast)
[1] 156321 141970
> TreeLength(c(tree2, tree2), yeast)
[1] 392695 156321
> TreeLength(c(tree2, tree), yeast)
[1] 392695 156321

The text was updated successfully, but these errors were encountered:

ms609 closed this as completed in

298015c

Owner

ms609 commented May 11, 2022 •

edited

Loading

Thanks for catching this – TreeLength.multiPhylo(concavity = Inf) was missing a check for edge ordering. Fix applied and test cases added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment