Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace .C with .Call #136

Closed
ms609 opened this issue Mar 28, 2023 · 0 comments · Fixed by #156
Closed

Replace .C with .Call #136

ms609 opened this issue Mar 28, 2023 · 0 comments · Fixed by #156

Comments

@ms609
Copy link
Owner

ms609 commented Mar 28, 2023

Dirk writes "[.C() is] discouraged given that using .Call() from R is so much more efficient"

TreeTools/R/tree_numbering.R

Line 37 in 8139af1

.C(`ape_neworder_pruningwise`, as.integer(nTip), as.integer(nNode),

@ms609 ms609 linked a pull request Mar 29, 2024 that will close this issue
Replace .C with .Call #156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace .C with .Call ms609/TreeTools
1 participant
@ms609