Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant issue with copy in and copy out #29

Open
Garethlomax opened this issue Jul 23, 2019 · 1 comment
Open

Significant issue with copy in and copy out #29

Garethlomax opened this issue Jul 23, 2019 · 1 comment

Comments

@Garethlomax
Copy link
Collaborator

issue on 125+ in lstm main forward module - we may not be copying in data at all correctly. As well as the copy in issue, issue with constructor means that copy in copy out may not be being assigned properly

@Garethlomax
Copy link
Collaborator Author

changing copy out and copy in behaviour to new design. copy out and copy in are returned to boolean.

copy out is now just list of copied out tensors in [[h,c].[h,c]] format. Forward takes as arguments x, and the copied out tensor list.

the forward class iterates over the boolean tensor list and copies in any requires, or initialises those needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant