Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change interface for read_enactment #22

Closed
mscarey opened this issue Jun 3, 2019 · 3 comments
Closed

change interface for read_enactment #22

mscarey opened this issue Jun 3, 2019 · 3 comments

Comments

@mscarey
Copy link
Owner

mscarey commented Jun 3, 2019

Make an understandable interface that doesn't require some of the parameters to come packed in a dict. Then change the names of this method and of Factor.from_dict to reflect the difference between this and the regular constructor method. Maybe Enactment.factory()?
@mscarey mscarey mentioned this issue Jun 18, 2019
Closed
@mscarey
Copy link
Owner Author

mscarey commented Aug 9, 2019

This method is being moved out of the core per #39

@mscarey
Copy link
Owner Author

mscarey commented Aug 14, 2019

This is difficult because whatever values get passed to read_enactment have to go to the log_mentioned_context decorator.

@mscarey mscarey changed the title change interface for Enactment.from_dict() change interface for read_enactment Aug 14, 2019
@mscarey
Copy link
Owner Author

mscarey commented Oct 21, 2019

Fixed in 7629083.

@mscarey mscarey closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mscarey