Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT fail #216

Closed
daniele-zurico opened this issue Nov 17, 2016 · 14 comments
Closed

AOT fail #216

daniele-zurico opened this issue Nov 17, 2016 · 14 comments
Labels

Comments

@daniele-zurico
Copy link

daniele-zurico commented Nov 17, 2016

Hi I'm trying to compile in Aot mode but it fail for that reason:

angular2-mdl/components/dialog-outlet/mdl-backdrop-overlay.component.ngfactory.ts:48:39 
Property 'zIndex' is private and only accessible within class 'MdlBackdropOverlayComponent'

I'm using 2.4.1

This is just an example but actually most of them fail.
The reason is that: things that the template accesses from the component must be public

@mseemann
Copy link
Owner

thx. will be fixed and will be in the release tomorrow...

@daniele-zurico
Copy link
Author

please do it :) I'm one step to have AOT ready just waiting you guys :)

@mseemann
Copy link
Owner

nice! i knew this is hard :)

@daniele-zurico
Copy link
Author

Sorry guys but mine was just an example there really a lot of them

@mseemann
Copy link
Owner

right now i have no idea how i could test that i do not miss any aot problems. do you have a list? i have only checked the properties with HostBinding..

@mseemann
Copy link
Owner

what is your env? angular-cli? which version? angular2 version?

@daniele-zurico
Copy link
Author

The version is 2.1.2 what I did is including in my app the materialModule. Not using the cli but my environment and unfortunately I don't have the list atm. I can try to do tomorrow morning but the rule is super easy. Everything that you declare in your class and will be used in your template have to be public

@mseemann
Copy link
Owner

a list would be great! also i would appreciate to see how you setup your project - i have a test project for cli that didn't had these problems with angular@2.1.2...

@mseemann mseemann reopened this Nov 17, 2016
@mseemann
Copy link
Owner

please check against version 2.4.3. the list is hopefully empty or even smaller...

@daniele-zurico
Copy link
Author

hey thanks a lot unfortunately there're still private var around.
Is much easier if I fork the project I fix them and I create a PR.
I'll let you know.

@mseemann
Copy link
Owner

👍
this is a little bit strange because my test project works with aot (https://github.com/mseemann/a2-mdl-webpack and live: http://mseemann.io/a2-mdl-webpack/) We'll see...

@ulic75
Copy link

ulic75 commented Dec 9, 2016

I'm using angular2-mdl 2.6.0 and compiling AOT with angular-webpack2-starter. I'm receiving numerous private property errors and also numerous "Supplied parameters do not match any signature of call target." errors. You can find my list at http://pastebin.com/zuMp8PEh. I'm a bit of a coding novice, but if you have questions I'll answer as best I can.

Also, since I'm still early on in my development I was able to remove all angular2-mdl references and rebuild and it does in fact behave as expected without angular2-mdl.

@mseemann
Copy link
Owner

mseemann commented Dec 9, 2016

afaik angular-webpack2-starter did not support aot: PatrickJS/PatrickJS-starter#885

@ulic75
Copy link

ulic75 commented Dec 9, 2016

Show what a n00b I am. Apparently I'm using this repo fork and didn't realize it was a fork.

https://github.com/qdouble/angular-webpack2-starter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants