Add support for ActiveSupport's TimeWithZone class #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that TZ data is not stripped Original author is Nathan Broadbent <nathan.f77@gmail.com>.
|
Rebase and fix spec. |
|
👍 |
|
Time doesn't implement to_msgpack. Why only ActiveSupport::TimeWithZone implements to_msgpack? |
|
Thank you for reply. But PR #37 is left for a long time and outdated. I think that this feature is optional. This patch do nothing when user doesn't have ActiveSupport. You can close/reject #37 and this PR if you don't want to merge this feature. Thanks. |
|
It seems uncommon change for msgpack users. Please do it in other gem if you need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that TZ data is not stripped
Original author is Nathan Broadbent nathan.f77@gmail.com.
See also #37