-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genesect Gen8 sprite inconsistency / missing Appletun-Gmax / contribution question(s) #110
Comments
|
Good catch! Yeah, I'm actually a little bit confused by the Genesect sprite now because originally the "standard" icon was, I think, actually different. But I don't remember exactly how it worked back then. If you check the I'm guessing that in Also yes, feel free to make a copy of Appletun, it seems I just totally forgot about that. As for Arceus, please feel free to make a PR for that too, but maybe you can make it a separate one since I'm looking at the sprites now and I think there may be some small changes I need to make to others. Like my Bug Arceus has red eyes and it shouldn't, so I should just double check them all. Regarding the project, maybe it'd be good to add that link and then also the link to the project page besides it? |
Yeah, it didn't notice the missing drive either until my second comment, haha. I wonder why they changed it. I've made a PR for the Appletun and Genesect changes #112 . I'll make a separate Arceus PR when I get the time tomorrow or the day after. That sounds like a good idea! |
Awesome. I'll have a look at it when I've got some time this weekend. |
I've just merged both your PRs. Thanks for your contribution! I just realized I forgot to add your link to the readme. I'll just do that now. |
Hello! Items 1-3 on the list below seemed small enough that I could contribute a fix, I just wanted to double check 1 and 3 before making a pull request.
genesect.png
While the shiny folder has two. The genesect-standard.png is the old, smaller sprite however.
genesect.png genesect-standard.png
Would it be preferred to remove the shiny/genesect-standard.png variant entirely or update it to the Gen8 sprite (and add it to the regular folder as well)?See comment belowThank you!
The text was updated successfully, but these errors were encountered: