Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Svelte v4 #174

Closed
pheuter opened this issue Jun 19, 2023 · 8 comments · Fixed by #179
Closed

Support for Svelte v4 #174

pheuter opened this issue Jun 19, 2023 · 8 comments · Fixed by #179
Labels
enhancement New feature or request
Milestone

Comments

@pheuter
Copy link

pheuter commented Jun 19, 2023

Svelte v4 is coming, would be nice to be able to continue using Svelecte.

@mskocik
Copy link
Owner

mskocik commented Jun 20, 2023

Yes, definitely

@mskocik mskocik added this to the v4.0 milestone Jun 20, 2023
@mskocik mskocik added the enhancement New feature or request label Jun 20, 2023
@pheuter
Copy link
Author

pheuter commented Jul 7, 2023

Allow me to bug you for an ETA on this, thanks.

@Buk1m
Copy link

Buk1m commented Jul 7, 2023

Is the 4.0.0-alpha.10 version compatible with svelte 4? Do you need any help with migrating?

@mskocik
Copy link
Owner

mskocik commented Jul 7, 2023

Next week, when I get back home, I can release new v4 alpha with svelte v4 support.

@mskocik
Copy link
Owner

mskocik commented Jul 7, 2023

Is the 4.0.0-alpha.10 version compatible with svelte 4? Do you need any help with migrating?

Not really. I started v4 branch before svelte v4 announcement. But only v4 will support v4 if that makes sense 😄

@mskocik mskocik mentioned this issue Jul 11, 2023
Merged
@mskocik
Copy link
Owner

mskocik commented Jul 11, 2023

Since v4.0.0-alpha.13 svelecte is compatible with svelte v4

npm install svelecte@next

@mskocik mskocik pinned this issue Jul 11, 2023
@pheuter
Copy link
Author

pheuter commented Jul 11, 2023

@mskocik I just tested v4.0.0-alpha.11 locally and while the peer dependency appears to work now, I'm getting a different error that suggests it not longer supports SSR in SvelteKit:

Internal server error: HTMLElement is not defined
      at eval (node_modules/svelecte/dist/lib/custom-element.js:89:31)
      at instantiateModule (file:///node_modules/vite/dist/node/chunks/dep-8609dc5d.js:55851:15) (x3)

Specifically, it doesn't appear to server-side render due to class SvelecteElement extends HTMLElement and HTMLElement not being available on the server.

@mskocik
Copy link
Owner

mskocik commented Jul 11, 2023

alpha13 should fix it

@mskocik mskocik unpinned this issue Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants