New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include modus test ID in denormalization #3

Open

paul121 opened this issue May 22, 2023 · 0 comments

Collaborator

paul121 commented May 22, 2023

farm_modus/src/Normalizer/ModusEventSoil.php

Lines 95 to 101 in 6a3c59e

    
           // Add a result. 
        
           $sample_object['results'][] = [ 
        
             'analyte' => $nutrient_result['Element'], 
        
             'value'   => $value, 
        
             'units'   => $nutrient_result['ValueUnit'], 
        
             // @todo Add modus_test_id. 
        
           ];

The catch is I haven't seen test IDs in modus v1 json... are these test IDs included in any v1 xml/json? or only v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment