Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PortAudio 19.7.0-2 C++ bindings package #10604

Closed
wants to merge 3 commits into from

Conversation

volkanorhan
Copy link
Contributor

@volkanorhan volkanorhan commented Jan 23, 2022

Adds portaudiocpp package (C++ bindings of portaudio-2.0 library)

@Biswa96
Copy link
Member

Biswa96 commented Jan 23, 2022

There is already a portaudio package. Is not this the same project? If yes, is it possible to add the changes in the existing package.

Co-authored-by: مهدي شينون (Mehdi Chinoune) <79349457+MehdiChinoune@users.noreply.github.com>
@volkanorhan
Copy link
Contributor Author

volkanorhan commented Jan 23, 2022

There is already a portaudio package. Is not this the same project? If yes, is it possible to add the changes in the existing package.

portaudio package doesn't contain C++ bindings. This package builds only C++ bindings of the portaudio. Of course this can be build together with portaudio but this is a different library than portaudio. On Linux, portaudiocpp is a different package, too.

@volkanorhan volkanorhan changed the title PortAudio 1~19.7.0-2 C++ bindings package PortAudio 19.7.0-2 C++ bindings package Jan 23, 2022
@Biswa96
Copy link
Member

Biswa96 commented Jan 24, 2022

On Linux, portaudiocpp is a different package, too.

Generally ArchLinux package naming scheme is followed here. Their portaudio PKGBUILD file uses --enable-cxx option which adds /usr/lib/libportaudiocpp.so file.

Upstream does not have cmake file in cpp bindings. IMO, the cmake file added here should be contributed to upstream first.

@volkanorhan
Copy link
Contributor Author

On Linux, portaudiocpp is a different package, too.

Generally ArchLinux package naming scheme is followed here. Their portaudio PKGBUILD file uses --enable-cxx option which adds /usr/lib/libportaudiocpp.so file.

Upstream does not have cmake file in cpp bindings. IMO, the cmake file added here should be contributed to upstream first.

There is a similar cmake file to be merged on mainstream, and I contributed some enhancements, too, but it will take too much time to have it on stable release version.
Anyway, I am closing this merge request, and I will make portaudio package to use autotools instead of cmake, because stable version doesn't have cmake file for C++ bindings.

@Biswa96
Copy link
Member

Biswa96 commented Jan 24, 2022

Portaudio was using cmake since this #9173. Would you like to wait a little please? Let me test this to existing portaudio package.

@volkanorhan
Copy link
Contributor Author

volkanorhan commented Jan 24, 2022

Portaudio was using cmake since this #9173. Would you like to wait a little please? Let me test this to existing portaudio package.

OK, I am waiting. Thanks @Biswa96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants