lmdb: Fix stack-allocated string and update python-lmdb #17095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - * This works as long as no function between the call to mdb_strerror | ||
| - * and the actual use of the message uses more than 4K of stack. | ||
| - */ | ||
| + // Fix the return of stack-allocated string |
There was a problem hiding this comment.
It's no longer stack-allocated if it's static.
There was a problem hiding this comment.
Yes, but before it was stack allocated, so I fixed it
There was a problem hiding this comment.
Your fix looks fine.
But I agree that the comment might be confusing when upstreamed if it is referring to code that was there but is no longer "visible".
Maybe, something along the lines of "Avoid potential issue with stack-allocated string by using static" would be clearer?
There was a problem hiding this comment.
Thank you for the suggestion, fixed
|
Notified LMDB devs: https://bugs.openldap.org/show_bug.cgi?id=10050 |
|
Please bump the pkgrel values in both PKGBUILD files. |
thomasfire
force-pushed
the
fix_lmdb_segfault
branch
from
ec74f3d
to
a7c27b1
Compare
…s on Clang platforms Signed-off-by: Egor Savkin <es@m-labs.hk>
thomasfire
force-pushed
the
fix_lmdb_segfault
branch
from
a7c27b1
to
1b18e81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.