hdf5: Fix ZLIB and SZIP #18328
Merged
hdf5: Fix ZLIB and SZIP #18328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2023
|
Would you like to explain how this change fixes the issue? |
|
Sure. There have been multiple upstream changes to the cmake recipe including removal of FindSZIP.cmake. This means prior configuration settings no longer work. libaec is also built by cmake so configuration there just involves pointing to the location where the libaec cmake configuration was stored. For Zlib there is a FindZLIB.cmake but it needs a hint to look at the MINGW root. |
|
See also conda-forge/hdf5-feedstock#207 That build uses autoconf rather than cmake though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18326