new git icon has white background on x86 desktop

[mikofski]

expected: git icon (git bash, gui, gtk) should have invisible background.
currently: git icon (on desktop) has which background

system: xp sp3 (x86)
msysgit: (git for windows) 1.7.11-preview20120704

also note:
git gui title bar icon is unreadable
gitk title bar icon is unchanged
on x64 (windows 7, haven't checked xp64) icon points to %PROGRAMFILES%\Git\etc\git.ico, but git is in Program Files (x86), not and echo %PROGRAMFILES% is Program Files (the x64 folder).

[sschuberth]

Yeah, I know about the white background for the 256-color icons. The problem is that 256-color icons can only have binary transparency, and using binary transparency makes the new icon look really bad when they are rasterized from the original vector graphic. So I decided to go with a white background for now. Maybe I can come up with something based on git-scm.com's favicon.

In the meantine, can you check why Windows XP is picking up the 256-colors icons instead of the true-color icons? I thought true-color icons are supported since Windows XP.

Edit: For reference, Windows XP supports 32-bit icons, which are 24-bit images with an 8-bit alpha channel.

[dscho]

@mikofski also note that nobody forces you to wait for @sschuberth to scratch your itch. It is not magic to work with icons, and you can do it just like the next person...

[mikofski]

Sorry, my mistake - the new icon is working fine on XPSP3(x86). The issue is only with W7(x64) and XPSP2(x64). I will look into it as soon as I get the chance. Thanks for the great work and cool new icons!

[sschuberth]

Ok, so I've sent a patch about "gitk title bar icon is unchanged" upstream. But can you elaborate what you mean with "git gui title bar icon is unreadable"?

[mikofski]

I hope you can see the image in this link. Basically the gitgui icon is just a blurry red diamond. The desktop icon is fine, ie transarent background which I'm docked and using 2 monitors, but when I am jus tusing the laptop by itself, that's when the which background shows up. I have to look at it on my Linux box, since I don't have gimp on my pc. I'll try to do that this week sometime, and try to figure out what's up. Thanks for reporting the gitk icon upstream, although I'll kinda miss the old git icon.

[sschuberth]

Thanks for the screenshot. Under which exact version of Windows did you take it?

[mikofski]

Windows XPSP3(x86). I'll have a look on Windows7(x64) and xp64 later if necessary, tomorrow?

[sschuberth]

I'm on Win 7 64-bit myself, so everything should be fine there as that's my testing platform. Win XP 64-bit would be interesting, though. I'd expect it to behave like Win XP 32-bit regarding the icons.

[mikofski]

I'm very sorry. My x86 laptop display setting was somehow 16bit, and the x64 machines (both W7 and XP) also had the display settings for 16bit; changed all to 32bit and white background is gone. Also It looks like with 32bit color, the git gui display is fine. Thanks @sschuberth for the tip, and I apologize for the unnecessary issue ticket. The blurry git-gui icons and white background desktop icon issue should be resolved - not a bug.

The only thing outstanding is to make sure the desktop icon on x64 machines points to Program Files (x86) and not %PROGRAMFILES%. I'll try to look over the inno-setup and see if I can change it.

[sschuberth]

As you can see here, "FileName" is the path to the icon, which uses "AppDir", which in turn equals ExpandConstant('{app}'), so everything seems to be correct as we're always using the path Git is installed to. Please make sure that your desktop icon is not a left-over or something.

[sschuberth]

For people using less than 32-bit colors for their display, the 8-bit icons now have binary transparency instead of a white background. Although this makes the logo's edges look a little rough it seems people prefer a transparent background over anti-aliasing.