Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect all functions from behaviour by default #8

Closed
msz opened this issue Oct 23, 2019 · 5 comments
Closed

protect all functions from behaviour by default #8

msz opened this issue Oct 23, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@msz
Copy link
Owner

msz commented Oct 23, 2019

No description provided.

@msz msz added the enhancement New feature or request label Oct 23, 2019
@msz msz added the good first issue Good for newcomers label Sep 24, 2020
@msz
Copy link
Owner Author

msz commented Oct 7, 2020

#54 added protect/1 for behaviour-implementation modules but not closing this just yet as it would be good to also add a protect/2 version for when the behaviour and implementation modules are different modules. cc @saneery if you'd like to tackle this too

@saneery
Copy link
Contributor

saneery commented Oct 8, 2020

Sure! you may assign the issue to me

@saneery
Copy link
Contributor

saneery commented Oct 8, 2020

@msz should we return exceptions then some function inside the implementation module doesn't have specs? Or decorate only those with specs?
The second seems is more reasonable to me

@msz
Copy link
Owner Author

msz commented Oct 8, 2020

Often the implementation module will be much larger than a behaviour, and can actually implement several behaviours and still have its own functions. So I think if we are protecting with a specific behaviour, we should only look at callbacks from that behaviour.

@msz
Copy link
Owner Author

msz commented Oct 11, 2020

Closed in #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants