Skip to content

Commit

Permalink
TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
mt-inside committed Oct 27, 2023
1 parent d7b8a24 commit c60f6b7
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions cmd/http-log/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ func main() {

log.Info("Connection state change", "state", cs)

// FIXME: h2, Envoy(h1), etc hold connections open, so we prolly need to hook IDLE to print
// - indeed, print-cert-repeating over h2 just has the conn go active,idle,active,etc. All seem like the same reqNo. Never get printed
// need to detect conn re-use somehow, and bump reqNo (and make new structs etc) on transition to active (but re-use the tcp info from the conn going to new omg)
// - but it goes idle >1 time. When? Seen: h2c's h2 upgrade (PRI or h1:Upgrade); TLS handshake
// when this is fixed, can put istio-demo back to h2 (appProto http2, h2UpgradePolicy)
if cs == http.StateClosed {
srvData := ctxt.SrvDataFromContext(ctx)
reqData := ctxt.ReqDataFromContext(ctx)
Expand Down

0 comments on commit c60f6b7

Please sign in to comment.