Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/cleanup translations and move to MT 5.0.0+ translation system #104

Open
1 of 5 tasks
OgelGames opened this issue Oct 19, 2020 · 6 comments
Open
1 of 5 tasks
Labels
Cleanup Cleanup of bad code or other redundant/unnecessary stuff Translations

Comments

@OgelGames
Copy link
Contributor

OgelGames commented Oct 19, 2020

It needs to be done at some stage...

Translations for technic are complete as of #289, expect for:

The other sub-mods still need to have their translations checked and completed.

@OgelGames OgelGames added the Enhancement New feature or request label Oct 19, 2020
@BuckarooBanzay
Copy link
Member

I don't have much experience with the translation system in general but it looks like the mod it is prepared for that:
The locale directory with the properly formatted files is there and the technic.getter does pretty much the same thing as minetest.get_translator() does

@OgelGames
Copy link
Contributor Author

Yeah, it's almost the same, the updating/cleanup will be harder than changing the translator.

Here is an example (which is what reminded me about it): https://github.com/ChaosWormz/teleport-request/pull/39/files

@BuckarooBanzay
Copy link
Member

Some work may have been done here: minetest-mods/technic#529

@OgelGames
Copy link
Contributor Author

That will help a lot 👍 Of course there will still be some work to do because of all the changes we have made...

Also probably better to wait until the network and chests updates are done before this.

@OgelGames OgelGames added the Cleanup Cleanup of bad code or other redundant/unnecessary stuff label Dec 20, 2020
@BuckarooBanzay
Copy link
Member

more progress from upstream: minetest-mods/technic#529

@S-S-X
Copy link
Member

S-S-X commented May 1, 2022

I think it would be better to close this issue and create multiple more specific issues for translations.

Bit more specific issue descriptions and narrowing individual issue scope can make workflow very beginner friendly / not require deep technical knowledge about underlying translation system.

Also increases visibility for progress tracking purposes.

@OgelGames OgelGames added Translations and removed Enhancement New feature or request labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Cleanup of bad code or other redundant/unnecessary stuff Translations
Projects
None yet
Development

No branches or pull requests

3 participants