Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to .net core... #9

Closed
tapika opened this issue Feb 4, 2022 · 6 comments
Closed

Port to .net core... #9

tapika opened this issue Feb 4, 2022 · 6 comments
Assignees
Milestone

Comments

@tapika
Copy link

tapika commented Feb 4, 2022

I know there was once upon a time following ticket:
#8

but it was closed long time ago.

Meanwhile - I would like to use logging + testing for testing, and I would prefer to use fastest proxy generator + fastest call dispatcher.

Would it be still possible to port NProxy to .net core ?

@mtamme
Copy link
Owner

mtamme commented Feb 5, 2022

Honestly, I don't have any experience in .NET Core. I am back in den good old Java world for several years now, but I will try to figure it out when there is time. So please be patient ;-)

@mtamme
Copy link
Owner

mtamme commented Apr 9, 2022

Hi,

Which target framework are you using? I've created a net5.0 branch. Can you check it out?

Thx

@tapika
Copy link
Author

tapika commented Apr 10, 2022

I think it would be the best to target .netstandard, as it will be compatible with .net framework and .net core as well.
But if not possible - then maybe report to all long living .net core versions - I'm at the moment using .net core 3.1, but I have also tried cross compatibility to .net framework & .net core 5.0 & .net core 6.0 - they should work as well, but at the moment my CI is testing only .net 3.1 on constant basis.

My proposal is to not to be bound to my own project, but just to be generic component, available to multiple end-users who wants to use it.

@tapika
Copy link
Author

tapika commented Apr 10, 2022

See also:

https://github.com/tapika/swupd/blob/master/docs/testing.md#mocking-and-verifying-log

LoggedMock.cs / LoggedMockInterceptor.cs - logged mock is probably the place where I could connect whole thing.

@mtamme
Copy link
Owner

mtamme commented Apr 18, 2022

I decided to target net40 and netcoreapp3.1 and the tests are running with net48 and net6.0.

Is it possible for you to just build NProxy by your own and test it within your project?

I've renamed the branch to cross-platform.

@mtamme
Copy link
Owner

mtamme commented Apr 22, 2022

I haven't published the NuGet package yet but one is available on AppVeyor.

@mtamme mtamme self-assigned this Apr 22, 2022
@mtamme mtamme closed this as completed Apr 22, 2022
@mtamme mtamme added this to the v3.0.0 milestone Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants