-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assetCount bug? #15
Comments
They are marked as removed. Interesting question. Sent from my iPhone
|
I think it will confuse user if assetCount > 0 but there is no tool asset reported by the agent. In addition, when new assets added to the system the count does not reflect the actual tool assets but it will be the total of removed assets + new tool assets. |
you can ask the agent to include removed assets and they will appear, marked as removed, This may necessitate another count in the standard to handle this capability. I agree it is confusing, but I don't know how to clarify the situation without causing another confusion. We may need an assetRemovedCount in the header. Any thoughts? Sent from my iPad
|
It must have something else to account for the removed assets. If the system runs long enough agent will accumulate many removed assets in the assetCount and your agent might not be able to handle all removed assets in the long run as asset ID keep changing. |
The standard specified that there are a fixed number of assets in the Therefor the max assets is fixed in most cases regardless of removed or On Wednesday, November 19, 2014, hulinning2 notifications@github.com
Sent from my iPhone |
Good. I think we just need to define a different attribute for number of removed assets. it would be best to be able to query for removed assets only instead of both. |
that's what i'm thinking as well. we can recommend for V1.4. thanks for raising this issue. Sent from my iPad
|
Refactored memory management in Agent class (#14)
assetCount does not clear after all assets have been removed.
The text was updated successfully, but these errors were encountered: