Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assetCount bug? #15

Closed
hulinning2 opened this issue Nov 18, 2014 · 7 comments
Closed

assetCount bug? #15

hulinning2 opened this issue Nov 18, 2014 · 7 comments

Comments

@hulinning2
Copy link
Collaborator

assetCount does not clear after all assets have been removed.

@wsobel
Copy link
Member

wsobel commented Nov 18, 2014

They are marked as removed. Interesting question.

Sent from my iPhone

On Nov 18, 2014, at 06:20, hulinning2 notifications@github.com wrote:

assetCount does not clear after all assets have been removed.


Reply to this email directly or view it on GitHub.

@hulinning2
Copy link
Collaborator Author

I think it will confuse user if assetCount > 0 but there is no tool asset reported by the agent. In addition, when new assets added to the system the count does not reflect the actual tool assets but it will be the total of removed assets + new tool assets.

@wsobel
Copy link
Member

wsobel commented Nov 19, 2014

you can ask the agent to include removed assets and they will appear, marked as removed, This may necessitate another count in the standard to handle this capability. I agree it is confusing, but I don't know how to clarify the situation without causing another confusion. We may need an assetRemovedCount in the header.

Any thoughts?

Sent from my iPad

On Nov 19, 2014, at 07:58, hulinning2 notifications@github.com wrote:

I think it will confuse user if assetCount > 0 but there is no tool asset reported by the agent. In addition, when new assets added to the system the count does not reflect the actual tool assets but it will be the total of removed assets + new tool assets.


Reply to this email directly or view it on GitHub.

@hulinning2
Copy link
Collaborator Author

It must have something else to account for the removed assets. If the system runs long enough agent will accumulate many removed assets in the assetCount and your agent might not be able to handle all removed assets in the long run as asset ID keep changing.

@wsobel
Copy link
Member

wsobel commented Nov 19, 2014

The standard specified that there are a fixed number of assets in the
agent, though with a backing store it could be ~infinite. The current
default is 1024 and can be increased through configuration variable
(documented). This will keep memeory and storage managable.

Therefor the max assets is fixed in most cases regardless of removed or
active.

On Wednesday, November 19, 2014, hulinning2 notifications@github.com
wrote:

It must have something else to account for the removed assets. If the
system runs long enough agent will accumulate many removed assets in the
assetCount and your agent might not be able to handle all removed assets in
the long run as asset ID keep changing.


Reply to this email directly or view it on GitHub
#15 (comment).

  • Will

Sent from my iPhone

@hulinning2
Copy link
Collaborator Author

Good. I think we just need to define a different attribute for number of removed assets. it would be best to be able to query for removed assets only instead of both.

@wsobel
Copy link
Member

wsobel commented Nov 19, 2014

that's what i'm thinking as well. we can recommend for V1.4.

thanks for raising this issue.

Sent from my iPad

On Nov 19, 2014, at 10:23, Linh Huynh notifications@github.com wrote:

Good. I think we just need to define a different attribute for number of removed assets. it would be best to be able to query for removed assets only instead of both.


Reply to this email directly or view it on GitHub.

@wsobel wsobel closed this as completed Jan 26, 2015
wsobel pushed a commit that referenced this issue Dec 10, 2019
Refactored memory management in Agent class (#14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants