Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllCards/AllSets for more formats #47

Closed
ZeldaZach opened this issue Oct 4, 2018 · 10 comments · Fixed by #441
Closed

AllCards/AllSets for more formats #47

ZeldaZach opened this issue Oct 4, 2018 · 10 comments · Fixed by #441
Assignees
@henry739
Labels
Enhancement New feature or request Good First Issue Good for newcomers
Milestone
v4.2

Comments

@ZeldaZach
Copy link
Member

Continuation of #178

Currently, we will build all sets in existence into these two files. Should we look into a limiting factor, or have different downloads? Technically, they're all real magic cards, so I'd like to keep them bundled. They have an annotation that they're not legal (silver boarder) and most people can infer that information.

Discussions welcome!
@ZeldaZach ZeldaZach added the More Information Needed Further information is requested label Oct 4, 2018
@ZeldaZach ZeldaZach mentioned this issue Oct 4, 2018
Closed
@KingSupernova31
Copy link

Doesn't the "legalities" field accomplish this? Un-cards, Proposal, etc have no legalities at all, whereas things like Chaos Orb and Shahrazad do. (They're just banned.)

@ZeldaZach ZeldaZach added the Enhancement New feature or request label Oct 29, 2018
@ZeldaZach ZeldaZach added this to the v4.2 milestone Oct 29, 2018
@ZeldaZach
Copy link
Member Author

I believe you are correct, @KingSupernova31 . People can read up on the legalities field to determine card types.

I do plan on making Standard.json, Modern.json, etc in the future. But that's a diff ticket.

@ZeldaZach ZeldaZach added the Invalid This doesn't seem right label Oct 30, 2018
@ancestral
Copy link

ancestral commented Dec 5, 2018 •
edited

I would love to have download links for the following:

  • Standard
  • Modern
  • Legacy
  • Vintage
  • Commander
  • No-Un Cards

(Sorry if this belongs in a different ticket…)

@ancestral
Copy link

Non-playable tournament cards like 1996 World Champion, Planechase Schemes and Vanguard cards exist in the No-Un Cards. Either this is a mistake, or we need a “tournament-compatible” download.

@ancestral ancestral reopened this Jan 9, 2019
@ZeldaZach
Copy link
Member Author

Those should be pulled out from the NoUn file. A sweep for "Not Legal" in Vintage should help clear that up

@ancestral
Copy link

I guess the question is, what’s the difference between no-Un and Vintage? Ante cards?

@ZeldaZach
Copy link
Member Author

Those are banned. Not legal is different

ZeldaZach added a commit that referenced this issue Jan 12, 2019
@ZeldaZach
Fix #47. Memorabilia is another type of thing that should be excluded
2135b1c 
Signed-off-by: Zach Halpern <ZaHalpern+github@gmail.com>
ZeldaZach added a commit that referenced this issue Jan 12, 2019
@ZeldaZach
Fix #47. Memorabilia is another type of thing that should be excluded
3a7133f 
Signed-off-by: Zach Halpern <ZaHalpern+github@gmail.com>
@ancestral
Copy link

Revisiting this. @staghouse supported me in the idea of having format-specific downloads beyond just Standard, Modern and Vintage, which is really what this ticket was about in the first place.

The suggestion is one for each of the formats Scryfall supports (Legacy, Brawl, Commander, Pauper, Penny Dreadful and Duel Commander). If you want to stick with Wizards-recognized formats only of those, all those minus Duel Commander and Penny Dreadful.

@ancestral ancestral reopened this Aug 19, 2019
@ancestral ancestral changed the title AllCards/AllSets for Legal cards only AllCards/AllSets for more formats Aug 19, 2019
@ancestral ancestral removed Invalid This doesn't seem right More Information Needed Further information is requested labels Aug 19, 2019
@ancestral ancestral mentioned this issue Aug 21, 2019
Closed
@ZeldaZach ZeldaZach added the Good First Issue Good for newcomers label Sep 10, 2019
@ZeldaZach
Copy link
Member Author

What I'm looking for now is essentially an expansion of what we offer

We have Vintage.json, Standard.json, etc. These files are all a subset of AllSets. I'm looking for VintageCards.json, StandardCards.json, etc which will be a subset of AllCards.

@henry739
Copy link
Contributor

Actively working on this; please could I be assigned?

@henry739 henry739 mentioned this issue Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henry739 henry739

Labels
Enhancement New feature or request Good First Issue Good for newcomers
Projects
None yet
Milestone
v4.2
Development

Successfully merging a pull request may close this issue.

Issue/Enhancement-47 More Formats
4 participants
@ancestral @ZeldaZach @KingSupernova31 @henry739