Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename/Alter "AttributeValues" #548

Closed
staghouse opened this issue Apr 25, 2020 · 1 comment
Closed

Rename/Alter "AttributeValues" #548

staghouse opened this issue Apr 25, 2020 · 1 comment
Assignees
@ZeldaZach
Labels
Enhancement New feature or request

Comments

@staghouse
Copy link
Member

MTGJSON Version: 5.0.0

Rename: The new AttributeValues file should be named back to its original "KeyValues" name as it is more precise.

Alter: The following data points need to be adjusted:

card =>

  • remove types
  • remove subtypes
  • remove supertypes
  • remove foreignData

set =>

  • remove code
  • add type

add foreignData (top level) =>

  • add language
@ZeldaZach ZeldaZach self-assigned this Apr 26, 2020
@ZeldaZach ZeldaZach added the Enhancement New feature or request label Apr 26, 2020
@ZeldaZach
Copy link
Member

Addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZeldaZach ZeldaZach

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staghouse @ZeldaZach