Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First feedback on examples #2

Closed
dietmarw opened this issue Oct 8, 2013 · 2 comments
Closed

First feedback on examples #2

dietmarw opened this issue Oct 8, 2013 · 2 comments

Comments

@dietmarw
Copy link
Collaborator

dietmarw commented Oct 8, 2013

Hi here follows my feed back on the examples you added so far (d02fefa):

  • NewtonCooling*: It is confusing why this cooling example actually shows a rising temperature behaviour. Wouldn't it be better to have a model where the ambient temperature is actually less than the initial temperature? (also present in all other variants of NewtonCooling
  • Backlash: Typo: behavior --> behaviour
  • StateSpace: Not clear why only ABCD is defined as partial but not the other. Maybe you plan to explain this in the book.
  • VectorTables: Don't use class as that should not really be used my modellers in any library. MSL also tries to get rid of it.

That's it for now. Got to run. I looked also through the rest. The component based parts are a bit more difficult to check without probably talking them through with you. I'm up for having a chat why you explain for what reason you've chosen that particular example. So I could give you feedback on that one too.

@xogeny
Copy link
Collaborator

xogeny commented Oct 11, 2013

I created separate tickets for the NewtonCooling*, StateSpace and VectorTables issues.

Note, "behavior" is the correct American spelling. The book will following American spelling. If you want the British version, ask @harmanpa to do a translation. :-)

@xogeny xogeny closed this as completed Oct 11, 2013
@dietmarw
Copy link
Collaborator Author

Well I guess the ModelicaSDK of @harmanpa contains already a parser that corrects all the horrible AE spelling to something proper :-)

xie-dongping referenced this issue in xie-dongping/ModelicaBook Sep 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants