Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roll lane lengths #10

Closed
mtolly opened this issue Mar 25, 2014 · 1 comment
Closed

Fix roll lane lengths #10

mtolly opened this issue Mar 25, 2014 · 1 comment
Assignees
Milestone

Comments

@mtolly
Copy link
Owner

mtolly commented Mar 25, 2014

A very small issue: the roll lane notes on pitches 126 and 127 should have their note-off event a very small amount of time (a few MIDI ticks) after the note-on of the last note in the roll. This was discussed in a Rock Band Creators forum thread, and is recommended by Harmonix authors as the right way to get a good-looking result in-game.

@mtolly mtolly added the bug label Mar 25, 2014
@mtolly mtolly self-assigned this Mar 25, 2014
@mtolly
Copy link
Owner Author

mtolly commented Mar 26, 2014

Now that I think about it, this should probably be done by a program. Having the manually positioned note-off event in the input MIDI is a bit ugly, and a program could consistently adjust it to be in the correct position during the build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant