-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HTTP/1.1 implementation respect read_timeout configuration #8
Comments
Hi, would this be a good first issue to tackle (if no one else is already)? |
Hi! Thanks for the offer of help! I've been thinking that this timeout work (as well as the existing HTTP2 timeout work referenced above) belong better as a configurable parameter in the underlying socket as implemented in Thousand Island. Having to carry a timeout value around in Bandit's state seems the wrong pace to do it when the If you're game for taking that work on it would be much appreciated. I've written up my initial thoughts on the matter at mtrudel/thousand_island#15 Once that work lands, the scope of this ticket can change to actually remove timeout code from the HTTP/2 side, since we'll be able to handle both cases intrinsically using the new Thousand Island timeout feature. WDYT? |
Awesome, sounds good! I'd love to help out with Thousand Island as well :) Thanks! |
This landed back in 46622b7 and I neglected to close this issue |
The HTTP/1.1 stack doesn't currently respect the top-level
read_timeout
parameter. This comes down mostly to passing it intoSocket.recv
calls and returning it on keepalive loops. For testing prior art, see https://github.com/mtrudel/bandit/blob/main/test/bandit/http2/protocol_test.exs#L62The text was updated successfully, but these errors were encountered: