Test fixes #30
Merged
Test fixes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtth do you still maintain this repo? Could you review/merge this bugfix, please? |
|
Hi @juhoautio, apologies for the slow reply and thank you for the PR. The CLI was built for Azkaban 2.0 and will require changes to support more recent versions, I'm not sure how large these changes are however. We should also make sure they are backwards-compatible to not break existing clients. |
mtth
reviewed
Jan 16, 2019
Current Azkaban version requires that the uploaded project file name ends with .zip
|
I added another fix for zip upload so that I could run the integration tests. With this code most of them still pass against the latest azkaban (built from source). I can look into fixing the rest of them as well (with #32 applied I get errors=3, failures=3), but separate PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running against a rather fresh Azkaban server installation built from source.
Does it make sense to continue fixing tests like this?
Does the cli target some specific azkaban version and is there some way to ensure that it remains compatible with any older versions that should be supported?
See also #29