Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After registering duplicate connection name, Connections tree is empty #1085

Closed
dyegoaurelio opened this issue Jan 5, 2023 · 1 comment · Fixed by #1089
Closed

After registering duplicate connection name, Connections tree is empty #1085

dyegoaurelio opened this issue Jan 5, 2023 · 1 comment · Fixed by #1089
Labels

Comments

@dyegoaurelio
Copy link
Contributor

dyegoaurelio commented Jan 5, 2023

Describe the bug
The new option to save passwords on vscode's keystore is registering the connection using only it's name as a unique identifier.

So by creating two connections that uses the SQLTools Driver Credentials, and have the exact same name, database and driver, the extension won't work until one connection is manually erased from the config file

image

I think the extension should either prevent duplicate connection names, or add a unique identifier to the connection ID.

@gjsjohnmurray
Copy link
Collaborator

This problem existed before 0.27.0 and is unrelated to the new capability for drivers to store passwords in the keystore. See #668 (comment)

@gjsjohnmurray gjsjohnmurray changed the title Extension crashes when registering duplicate connection name After registering duplicate connection name, Connections tree is empty Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants