Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub code base for literals 1695 and 1694 #1141

Open
kutschke opened this issue Nov 18, 2023 · 1 comment
Open

Scrub code base for literals 1695 and 1694 #1141

kutschke opened this issue Nov 18, 2023 · 1 comment

Comments

@kutschke
Copy link
Collaborator

Most of these should use the value of the nominal DR period from the GlobalConstantsService. Maybe some need to use an event by event number that will ultimately come from the event header produced by the DAQ. There is currently an MC data product with the event by event value.

Be sure to check all .hh, .cc, .fcl and SimpleConfig .txt files.

@rlcee
Copy link
Collaborator

rlcee commented Nov 19, 2023

Some uses are very secondary, like histogram boundaries, or nominal acceptance
Validation/src/ValKalSeed.cc: if (t0 > 700.0 && t0 < 1695.0) {
do you want every reference fixed, even this sort of marginal ones?
In this line, you can also see a nominal 700, should that also be in GlobalConstants?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants