New country emojis

[jasonrudolph]

As part of #40, and following in the footsteps of #25 and #26, this pull request aims to add all of the country flags.

TODO

• Proof-of-concept: Add countries "AD" (Andorra 🇦🇩) through "AZ" (Azerbaijan 🇦🇿)
• Get feedback from @muan on the approach
• Add remaining countries: "BA" (Bosnia & Herzegovina 🇧🇦) through "ZW" (Zimbabwe 🇿🇼)

@muan: How does this look so far? What should I change about the approach before adding the remaining countries?

[muan]

✨ thank you so much! just one thing to note here: they should be ordered like OSX (can be found in the native emoji picker):

I have yet to find a text version of this order though. Easiest way would be to insert them one by one using the picker 😂.

And I think we can update the keys programmatically in one go once a category is finished. 👍 I also just added test on master for counting each category has the right number of emojis:

[jasonrudolph]

@muan: Thanks for the quick feedback!

just one thing to note here: they should be ordered like OSX (can be found in the native emoji picker)

As of 2a4451c, the first 16 countries (i.e., all the ones that start with "A") are in the order shown in the OS X emoji picker:

With that update in place, how is this looking so far?

[jasonrudolph]

Most of the country flags use the ISO 3166-2 country code as the emoji code. Chile's ISO code is "cl", but "cl" is already used by one of the previously-existing emojis, so I'm proposing that we use "chile" as the emoji code here.

[jasonrudolph]

Most of the country flags use the ISO 3166-2 country code as the emoji code. The ISO code to use here would be "cd", but "cd" is already used by one of the previously-existing emojis, so I'm proposing that we use "drc" as the emoji code here, since that seems to be a commonly-used abbreviation.

[muan]

All seems good to me! 👍

[jasonrudolph]

This is really close now. I see one test failure:

There are 246 emojis in "flags", but the expected number is 247

Off by one. Oh no. 🙀

@muan: Can you share how you got the counts that were introduced in 3a48994? That might help me track down the missing emoji.

[jasonrudolph]

@muan: Can you share how you got the counts that were introduced in 3a48994? That might help me track down the missing emoji.

Never mind. I see that there are indeed 247 flags:

Now I just have to track down the one that I'm missing. 🔍

[muan]

👋 Just saw that Slack prepends all the flag emojis with flag-, what do you think about doing that here as well?

Also, looks like the EU flag is missing 😁 🇪🇺🇪🇺🇪🇺

[jasonrudolph]

looks like the EU flag is missing 😁 🇪🇺🇪🇺🇪🇺

Thanks for catching that, @muan! 6bd97d0 adds the EU flag. And with that, we now have all 247 flags in place. 💃

Just saw that Slack prepends all the flag emojis with flag-, what do you think about doing that here as well?

Would you want to change the existing flag emojis to use that prefix as well? For example, would you want to change :es: to :flag-es:? If so, that would mean that apps like http://emoji.muan.co/ and https://github.com/muan/mojibar would output :flag-es: instead of :es:, right? And if that's true, then those apps would be outputting emoji codes that are incompatible with the emoji aliases used by GitHub and other services that use https://github.com/github/gemoji. Is that a concern?

[muan]

And if that's true, then those apps would be outputting emoji codes that are incompatible with the emoji aliases used by GitHub and other services that use https://github.com/github/gemoji. Is that a concern?

Ah you're totally right, let's keep it as is.

So this is done then? 🌟

[muan]

Also don't worry about the conflicts I can resolve them when merging. 👍

[jasonrudolph]

So this is done then?

Indeed! 😸

[muan]

⭐ ⭐ ⭐ ⭐ ⭐ ⭐ ⭐ ⭐ ⭐ ⭐
Thank you so much! 💥