iOS 9.1 People emoji 🙃

[nelsonpecora]

Added all the people emoji, 🕵found here:

Part of #24, but there are still a lot to go. Anyone want to help? 🤘

(Note: I wasn't sure how to order them, so I ended up putting them where I thought they'd logically go. Not important for accessing the library, but might help/hinder maintainability of the list)

[nelsonpecora]

🎉 tests pass 🎉

The simple map will be recompiled/updated in the prepublish script, correct? I don't have do do anything to it?

[wbinnssmith]

\o/ !!

looks awesome 🎉!! Would love to help. Is there a particular reason you did one commit per emoji?

For reference it looks like the official unicode descriptions are here, though it looks like the emojipedia ones are identical.

re: the simple map, it does get updated on prepublish, but it's checked into the repo for now (@muan this is up to you obviously) since some folks either find it more accessible or use bower or something like that. It could also just be regenerated and checked in when the lib gets versions.

@muan: is there a reason for the keys option when the user of the lib could just use Object.keys (or the equivalent in other langs) to get this same list? I might be missing something ¯_(ツ)_/¯

Super excited, awesome work 😄

[muan]

@yoshokatana 😍 thank you so much!

I wasn't sure how to order them, so I ended up putting them where I thought they'd logically go.

I'd go with however it's ordered/categorized in iOS/OSX.

is there a reason for the keys option when the user of the lib could just use Object.keys (or the equivalent in other langs) to get this same list? I might be missing something ¯_(ツ)_/¯

I added that because Object.keys returns the keys ordered by alphabets (with 💯 being the first) instead of the order as appears in the file (with 😀 being the first). Might be useful to add a script to update that as well.

[nelsonpecora]

Ahh, makes sense. I think that's fine for now, as long as people know they need to update the keys when they add new emoji. 😅

[rileyjshaw]

😞 sad that emoji doesn't just order itself correctly in the unicode space!

Just to check that I understand correctly, does keys correspond roughly with count from this emoji index?

[muan]

Just to check that I understand correctly, does keys correspond roughly with count from this emoji index?

Yup!

[jasonrudolph]

@muan: Are there any other updates that need to happen in this pull request before it's ready to merge?

[muan]

Thanks @yoshokatana, I've updated it with the iOS order.

Now 6 categories to go!!!