Fix for Erratic behavior(s) after launch #1179, additional comment for …

…#1178

mucommander-core/src/main/java/com/mucommander/ui/dialog/pref/general/AppearancePanel.java

@@ -633,6 +633,11 @@ private void initializeCustomLookAndFeels() {
      * Initialises the list of available look&feels.
      */
     private void initializeAvailableLookAndFeels() {
+        while (!WindowManager.getInstance().isAdditionalLafsLoaded()) {
+            try {
+                Thread.sleep(100);
+            } catch (InterruptedException e) {}
+        }
         // Loads all available look and feels.
         lookAndFeels = UIManager.getInstalledLookAndFeels();
 

mucommander-core/src/main/java/com/mucommander/ui/main/MainFrame.java

@@ -44,6 +44,7 @@
 import javax.swing.JLayeredPane;
 import javax.swing.JPanel;
 import javax.swing.JSplitPane;
+import javax.swing.SwingUtilities;
 import javax.swing.WindowConstants;
 import javax.swing.table.TableColumnModel;
 
@@ -205,8 +206,16 @@ public Insets getInsets() {
 
         executor.execute(() -> {
             // Create menu bar (has to be created after toolbar) - ok, but why?
+            // PSko - I guess it is related to loading Actions and that icons
+            // for toolbar action should have icons, but in menu they should not.
+            // However, still I don't get how setting the icon to null here in MenuToolkit#addMenuItem
+            // impacts menu icons....... if nullify is commented-out there, then icons all of sudden
+            // show in the menu causing this: https://github.com/mucommander/mucommander/issues/1178
             MainMenuBar menuBar = new MainMenuBar(this);
-            getJFrame().setJMenuBar(menuBar);
+            SwingUtilities.invokeLater(() -> {
+                getJFrame().setJMenuBar(menuBar);
+                getJFrame().revalidate();
+            });
         });
 
         // Create the split pane that separates folder panels and allows to resize how much space is allocated to the

mucommander-core/src/main/java/com/mucommander/ui/main/WindowManager.java

@@ -426,4 +426,8 @@ public void configurationChanged(ConfigurationEvent event) {
     			setLookAndFeel(lnfName);
     	}
     }
+
+    public boolean isAdditionalLafsLoaded() {
+        return additionalLafsLoaded;
+    }
 }