Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Erratic behavior(s) after launch #1181

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix for Erratic behavior(s) after launch #1181

merged 2 commits into from
May 31, 2024

Conversation

pskowronek
Copy link
Member

@pskowronek pskowronek commented May 9, 2024 •
edited

Fix for Erratic behavior(s) after launch #1179:

  • ad bug 1 - the problem is caused by menu items being constructed in the background for a faster muC launch. The JFrame was not "revalidated" after updating the menu items
  • ad bug 2 - the problem was kinda race condition related, caused by loading additional L&Fs in the background (deferred loading) for a faster muC launch. When Preferences were opened and L&Fs loading finished just after that, the L&Fs dropdown was in unstable condition. The bug has nothing to do with custom theme etc.

It contains additional comment that may help solving #1178
@ahadas - let's continue conversation in #1178

@pskowronek pskowronek requested a review from ahadas as a code owner May 9, 2024 18:26
@ahadas ahadas linked an issue May 13, 2024 that may be closed by this pull request
[Bug] Erratic behavior #1179
Closed
1 task
@pskowronek
Copy link
Member Author

@ahadas - let's merge this fix and release minor update to muC?

@ahadas ahadas merged commit 396dc59 into mucommander:master May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Erratic behavior
2 participants
@pskowronek @ahadas