Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [vLLM] Ability to use the tokenizer template #1989

Closed
golgeek opened this issue Apr 10, 2024 · 0 comments · Fixed by #1990
Closed

feat: [vLLM] Ability to use the tokenizer template #1989

golgeek opened this issue Apr 10, 2024 · 0 comments · Fixed by #1990
Labels
enhancement New feature or request

Comments

@golgeek
Copy link
Collaborator

golgeek commented Apr 10, 2024

Is your feature request related to a problem? Please describe.

Most models contain the template definition for the OpenAI chat endpoint in their tokenizer_config.json file on HF.
Redeclaring the template in LocalAI seems a bit counter-productive when it could be automagically applied.

Describe the solution you'd like

Model definition contains the following parameter:

template:
   use_tokenizer_template: true

If this parameter is set, on OpenAI chat endpoints (outside of the scope of functions), LocalAI doesn't even attempt to look at templating the prompt and passes the messages slice down the line to the vLLM python backend, which will apply the templating.

Additional context

PR incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant