Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change meme getter / bot photo sender #48

Closed
Mueller-Patrick opened this issue Mar 11, 2020 · 2 comments
Closed

Change meme getter / bot photo sender #48

Mueller-Patrick opened this issue Mar 11, 2020 · 2 comments
Assignees
@Mueller-Patrick
Labels
efficiency Something can be made more efficient

Comments

@Mueller-Patrick
Copy link
Owner

At the moment, if you want to send a photo, you have to include the logic to check if this is the file itself or just the file_id. Include this in either function to prevent some goddamn shit duplicate code.
@Mueller-Patrick Mueller-Patrick self-assigned this Mar 11, 2020
@Mueller-Patrick
Copy link
Owner Author

Best practice would probably be to include it in the sendPhoto function.

@Mueller-Patrick Mueller-Patrick added the efficiency Something can be made more efficient label Mar 11, 2020
@Mueller-Patrick
Copy link
Owner Author

Due to the port to AWS Lambda, photo sending is no longer possible / required. Therefore closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mueller-Patrick Mueller-Patrick

Labels
efficiency Something can be made more efficient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mueller-Patrick