-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish arm docker container as well as amd64 #314
Comments
+1 to this request. I would be happy to contribute to getting this integrated in the release script as well. A few observations,
|
Correct, I'm currently running
I'm currently trying to move away from TravisCI, which sadly has become just too unreliable. We could achieve something similar with GitHub Actions, of course, but I think ideally we integrate this with goreleaser. Contributions are more than welcome here! ❤️ |
Hey I'm not familiar with Github Actions but I've attempted to add the I was able to push to docker hub with multiple archs: https://hub.docker.com/r/rhnvrm/beehive/tags For setting up buildx with multi arch you will need to do the following locally:
If you think this is enough, I can send a PR. |
Found this recently, https://github.com/crazy-max/ghaction-docker-buildx Should we try adding this? |
@rhnvrm Haven't tried |
Hey, just read a bit more about this. Docker Hub also seems to provide it with pre/post hooks. This repo shows how it can be done: https://github.com/ckulka/docker-multi-arch-example It seems to rely on https://github.com/estesp/manifest-tool Both methods have their merits. One benefit, of setting up using buildx, might be that we can have a relatively easier way to build and push from local (if needed). |
Another option would be using the already existing goreleaser setup (see |
I had explored this option as well but landed on goreleaser/goreleaser#530 |
Hello, |
It seems like the docker-buildx repo I had linked earlier has been moved under https://github.com/docker/setup-buildx-action I can give it a try with a new PR. What do you say @muesli ? |
@rhnvrm Yeah, go ahead ❤️ Since goreleaser support is still WIP I'd say we should explore this route. |
For testing, I created a dummy tag and pushed it in my fork: https://hub.docker.com/repository/docker/rhnvrm/beehive/tags?page=1 After merging, any tag pushed will be pushed to your dockerhub. Two secrets will need to be set up:
|
Should hopefully be simple enough; it builds just fine using the existing Dockerfile (to https://hub.docker.com/repository/docker/cerebrate/beehive , for example), but it would be good to have an official image that keeps pace with releases.
The text was updated successfully, but these errors were encountered: