-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Add dark mode scrollbar #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have proposed an improved version, it handles:
- Add support for Firefox
- Add support for the corner color:
- Improve the contrast radio: https://webaim.org/resources/contrastchecker/?fcolor=404040&bcolor=191919.
- Add a min size for the thumb, as the default version has (otherwise it might be too small to be noticed)
- Add an "active" color when dragging with even more contrast.
Before
After
packages/grid/x-grid-modules/src/components/styled-wrappers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
packages/grid/x-grid-modules/src/components/styled-wrappers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
I'm testing on Windows now. |
All good on Windows. For those who wonder, the solution is coming from StackOverflow, not a question, from their source 😄. |
Let's discuss this in a separate issue so that we don't make this PR too noisy. |
Sure, done: mui/material-ui#22594 |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Closes #260