Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component demo: app bar with expandable search field #12651

Closed
2 tasks done
dandv opened this issue Aug 25, 2018 · 3 comments · Fixed by #12695
Closed
2 tasks done

Component demo: app bar with expandable search field #12651

dandv opened this issue Aug 25, 2018 · 3 comments · Fixed by #12695
Labels
docs Improvements or additions to the documentation new feature New feature or request

Comments

@dandv
Copy link
Contributor

dandv commented Aug 25, 2018

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

A common pattern is to have a search field in the app bar, which expands when the search icon is clicked/touched. A demo of this pattern would be useful.

Spec: https://material.io/design/navigation/search.html

Current Behavior

Couldn't find such a demo at https://material-ui.com/demos/app-bar/, and the blog layout example has a dummy search button.

Examples

@oliviertassinari oliviertassinari added new feature New feature or request docs Improvements or additions to the documentation labels Aug 25, 2018
@adeelibr
Copy link
Contributor

Can I work on this enhancement? If that's okay

@mbrookes
Copy link
Member

@adeelibr The docs example is a good starting point.

@adeelibr
Copy link
Contributor

I have added a PR for this, I'll try to be more quick next time. #12695

I followed the docs, I hope this is the correct approach. @mbrookes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants