Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui] Consider supporting system props in Sheet #43323

Closed
LvChengbin opened this issue Aug 16, 2024 · 1 comment
Closed

[joy-ui] Consider supporting system props in Sheet #43323

LvChengbin opened this issue Aug 16, 2024 · 1 comment
Assignees
@aarongarciah
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) package: joy-ui Specific to @mui/joy

Comments

@LvChengbin
Copy link

LvChengbin commented Aug 16, 2024 •
edited by github-actions bot
Loading

Summary

Why not consider allowing the <Sheet /> component of JoyUI to support system properties? That would provide more convenience for writing code.

Examples

No response

Motivation

No response

Search keywords: Joy sheet system properties
@LvChengbin LvChengbin added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 16, 2024
@aarongarciah aarongarciah self-assigned this Aug 16, 2024
@aarongarciah aarongarciah changed the title Consider to support system properties in <Sheet /> component of Joy. [joy-ui] Consider supporting system props in <Sheet /> component of Joy. Aug 16, 2024
@aarongarciah aarongarciah changed the title [joy-ui] Consider supporting system props in <Sheet /> component of Joy. [joy-ui] Consider supporting system props in Sheet Aug 16, 2024
@zannager zannager added the package: joy-ui Specific to @mui/joy label Aug 16, 2024
@siriwatknp siriwatknp added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 21, 2024
@siriwatknp
Copy link
Member

We won't move forward with the system props, it's better to rely on only sx prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarongarciah aarongarciah

Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@LvChengbin @aarongarciah @siriwatknp @zannager