Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Some fixes to the Link component page #16345

Merged
merged 3 commits into from
Jun 25, 2019

Conversation

kyarik
Copy link
Contributor

@kyarik kyarik commented Jun 23, 2019

  • Fixed some typos
  • Added missing punctuation
  • Added backticks around window.opener

- Fixed some typos
- Added missing punctuation
- Added backticks around `window.opener`
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 23, 2019

No bundle size changes comparing 9417f32...8d4fc13

Generated by 🚫 dangerJS against 8d4fc13

@joshwooding joshwooding added the docs Improvements or additions to the documentation label Jun 23, 2019
kyarik and others added 2 commits June 23, 2019 23:55
Co-Authored-By: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 24, 2019

@kyarik I like the proof-reading you have done on WebFundamentals. If for some reason, you happen to run a similar effort here. I would appreciate if it could be done in batches, rather than in one line pull request changes. Each pull request has an overhead for us, we have to review it.

Anyway, thanks for looking into our documentation :)

@kyarik
Copy link
Contributor Author

kyarik commented Jun 24, 2019

@oliviertassinari Sure, if you prefer, I can batch changes related to several pages (rather than one page at a time) as long as they are small (like in this pull request).

@oliviertassinari oliviertassinari merged commit d31104d into mui:master Jun 25, 2019
@oliviertassinari
Copy link
Member

@kyarik Thanks

@kyarik kyarik deleted the patch-1 branch June 25, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants