Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeItem] Use the ‘endIcon’ prop where appropriate #17488

Merged
merged 2 commits into from
Sep 21, 2019
Merged

[TreeItem] Use the ‘endIcon’ prop where appropriate #17488

merged 2 commits into from
Sep 21, 2019

Conversation

chocolatl
Copy link
Contributor

@chocolatl chocolatl commented Sep 19, 2019

Closes #17476

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 19, 2019

Details of bundle changes.

Comparing: e91f970...d60a7ae

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 331,962 331,962 90,633 90,633
@material-ui/core/Paper 0.00% 0.00% 68,660 68,660 20,458 20,458
@material-ui/core/Paper.esm 0.00% 0.00% 62,098 62,098 19,203 19,203
@material-ui/core/Popper 0.00% 0.00% 28,397 28,397 10,159 10,159
@material-ui/core/Textarea 0.00% 0.00% 5,082 5,082 2,132 2,132
@material-ui/core/TrapFocus 0.00% 0.00% 3,766 3,766 1,596 1,596
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,348 16,348 5,818 5,818
@material-ui/core/useMediaQuery 0.00% 0.00% 2,488 2,488 1,050 1,050
@material-ui/lab 0.00% -0.00% 154,783 154,783 46,921 46,920
@material-ui/styles 0.00% 0.00% 51,420 51,420 15,288 15,288
@material-ui/system 0.00% 0.00% 15,581 15,581 4,351 4,351
Button 0.00% 0.00% 78,633 78,633 24,021 24,021
Modal 0.00% 0.00% 14,542 14,542 5,114 5,114
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 69,963 69,963 21,856 21,856
Slider 0.00% 0.00% 75,084 75,084 23,184 23,184
colorManipulator 0.00% 0.00% 3,835 3,835 1,519 1,519
docs.landing 0.00% 0.00% 54,267 54,267 14,345 14,345
docs.main 0.00% 0.00% 597,961 597,961 191,048 191,048
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 302,849 302,849 87,078 87,078

Generated by 🚫 dangerJS against d60a7ae

@mbrookes mbrookes added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Sep 19, 2019
@mbrookes
Copy link
Member

Does this warrant a test?

@oliviertassinari oliviertassinari changed the title [TreeItem] Fix invalid prop ‘endIcon’ #17476 [TreeItem] Use the ‘endIcon’ prop where appropriate Sep 19, 2019
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Sep 19, 2019
@oliviertassinari
Copy link
Member

Does this warrant a test?

This is probably @joshwooding to say :).

@eps1lon
Copy link
Member

eps1lon commented Sep 19, 2019

Does this warrant a test?

After something already broke? I hope so.

@joshwooding
Copy link
Member

We should probably add tests that the icon override props work.

@oliviertassinari
Copy link
Member

I have added a test case; we should be able to improve it in the future.

@oliviertassinari oliviertassinari merged commit 0c3a980 into mui:master Sep 21, 2019
@oliviertassinari
Copy link
Member

@chocolatl Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TreeItem] Prop "endIcon" is not used
6 participants