[icons] Synchronize icons #26302
Merged
[icons] Synchronize icons #26302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
new feature
Since the svg baseline is checked in, we can still regenerate lib if any underlying script changed.
eps1lon
force-pushed
the
core/vendor-material-icons
branch
from
722d223
to
0b4af24
Compare
oliviertassinari
approved these changes
May 15, 2021
|
My GitHub stats are gonna be so good this month 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed:
Ecoand all its variantsComprehensive diff: https://gist.github.com/eps1lon/2af3c98d37fa88d14e1b2145555424e9
By commit review is advised. Ignore changes
packages/material-ui-icons/libandpackages/material-ui-icons/srcwhen reviewing.New icons are ignored for now until we can work out #26240.
The motivation for this update is to check in the baseline svgs (i.e. vendor them in) so that we can make updates to the publish pipeline without having to update icons.
Right now one has to run
src:downloadif they want to change the icons source. But since we can't download a specific revision of the icons you also introduce unrelated changes.By checking in the svg baseline (i.e.
material-icons/) we can changesrc:iconsand only get changes we directly introduce.With #26268 we don't actually need
srcanymore so I removed it.Preview: https://deploy-preview-26302--material-ui.netlify.app/components/material-icons/