Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Thumb shifts to the right upon clicking #76

Closed
danilo-leal opened this issue Jan 17, 2024 · 1 comment · Fixed by #373
Closed

[Slider] Thumb shifts to the right upon clicking #76

danilo-leal opened this issue Jan 17, 2024 · 1 comment · Fixed by #373
Assignees
@mj12albert
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!

Comments

@danilo-leal
Copy link
Contributor

danilo-leal commented Jan 17, 2024 •
edited
Loading

Search keywords: slider, base-ui, thumb

As surfaced in mui/material-ui#40332, when you click on the Slider's thumb, there's a slight shift to the right, making it stay misaligned in relation to the tip of the cursor.
@michaldudak michaldudak transferred this issue from mui/material-ui Feb 27, 2024
@michaldudak michaldudak changed the title [base-ui][Slider] Thumb shifts to the right upon clicking [Slider] Thumb shifts to the right upon clicking Feb 27, 2024
@michaldudak michaldudak added component: slider This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Feb 27, 2024
@colmtuite colmtuite mentioned this issue Mar 21, 2024
Closed
@mj12albert mj12albert mentioned this issue May 8, 2024
Merged
@mj12albert
Copy link
Member

In #373 I've fixed it so that clicks that land on the thumb will not change the value or shift the thumb: https://deploy-preview-373--base-ui.netlify.app/experiments/slider/

@mj12albert mj12albert self-assigned this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mj12albert mj12albert

Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Slider] New Slider components and hook mj12albert/base-ui
3 participants
@michaldudak @mj12albert @danilo-leal