Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module 'react-popper' #11197

Closed
mkbctrl opened this issue May 1, 2018 · 22 comments
Closed

Cannot find module 'react-popper' #11197

mkbctrl opened this issue May 1, 2018 · 22 comments
Assignees
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it

Comments

@mkbctrl
Copy link

mkbctrl commented May 1, 2018

In my React-Meteor app after upgrading the materiali ui to the latest version today I have noticed weird behaviour:

screen shot 2018-05-01 at 17 52 25

After downgrading to beta-41 everything goes back to normal.

@mosvov
Copy link

mosvov commented May 1, 2018

I get same error for 1.0.0-beta.44 and 1.0.0-beta.40

@oliviertassinari
Copy link
Member

oliviertassinari commented May 1, 2018

react-popper has just cut a release after #11196: floating-ui/react-popper#160

@oliviertassinari
Copy link
Member

I confirm, it's just broken.

@oliviertassinari
Copy link
Member

Use react-popper@0.10.1 for now.

@oliviertassinari oliviertassinari added external dependency Blocked by external dependency, we can’t do anything about it bug 🐛 Something doesn't work labels May 1, 2018
@oliviertassinari
Copy link
Member

This should be ok with react-popper@0.10.4

@timothyallan
Copy link

Just to clarify: the solution is to install react-popper as well as material ui?

@oliviertassinari
Copy link
Member

oliviertassinari commented May 2, 2018

@timothyallan No, it's to make sure that the yarn/npm's resolution of this transitive dependency (react-popper) is OK (>= 0.10.4 || <= 0.10.1).

@timothyallan
Copy link

cool, installing react-popper as well as material ui fixes it for us on b44 ;)

@insidewhy
Copy link

I installed react-popper as well as material-ui and I still get the message about missing react-popper... it happens only in watch mode and only on alternate compilations!! yarn 1.6.

@insidewhy
Copy link

I'm using react-popper 0.10.4 also :(

@go2ready
Copy link

Same here, happened only on alternate compilations for

/node_modules/@material-ui/core/Tooltip/Tooltip.d.ts
(2,30): Cannot find module 'react-popper'.

@acro5piano
Copy link

I have the same problem with these packages and settings:

package.json

        "typescript": "2.8.3",
        "@material-ui/core": "^1.2.1",
        "@material-ui/icons": "^1.1.0",
        "react-scripts-ts": "^2.16.0",
        "webpack-dev-server": "^2.11.2"

tsconfig.json

{
    "compilerOptions": {
        "baseUrl": ".",
        "outDir": "build/dist",
        "target": "es5",
        "lib": ["es6", "dom"],
        "sourceMap": true,
        "jsx": "react",
        "allowSyntheticDefaultImports": true,
        "noImplicitReturns": true,
        "strictNullChecks": true,
        "strict": true,
        "noFallthroughCasesInSwitch": true,
        "rootDirs": [
            "src",
            "src/stories"
        ],
        "typeRoots": [
          "node_modules/@types"
        ],
        "paths": {
            "@root/*": ["./src/*"]
        }
    },
    "include": ["src/**/*"],
    "exclude": [
        "node_modules",
        ".git"
    ]
}

I also tried typescript 2.9.1 but couldn't fix the error.

I would like to create reproducing repo.

Thanks!

@mkbctrl
Copy link
Author

mkbctrl commented Jun 13, 2018 via email

@acro5piano
Copy link

@mkbctrl

Thanks for the comment. Which version of material-ui do you use now?

@mkbctrl
Copy link
Author

mkbctrl commented Jun 13, 2018 via email

@acro5piano
Copy link

Okay, thanks!

@akazakou
Copy link

akazakou commented Jul 7, 2018

Any progress with it?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 7, 2018

@akazakou react-popper is on it's way out of Material-UI. It should be solved with next release. I'm working on a Popper component, sharing the same concepts with Popover.

@oliviertassinari oliviertassinari self-assigned this Jul 7, 2018
@akazakou
Copy link

akazakou commented Jul 7, 2018

@oliviertassinari thank you! But it anyway, maybe it helps you resolve the problem #11266 (comment)

@richtera
Copy link

richtera commented Jul 19, 2019

I ran into a variation of this. It seems somewhere in the code is says

import warning from "warning";

instead of

import warning from "./warning";

or something similar. Is this a know issue? I will roll back to 1.2.1 to see if that fixes it.

@richtera
Copy link

But this seems react-popper related and not material-ui. Checking there also.

@oliviertassinari
Copy link
Member

@richtera We do no longer use react-popper in v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

No branches or pull requests

9 participants