-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find module 'react-popper' #11197
Comments
I get same error for 1.0.0-beta.44 and 1.0.0-beta.40 |
react-popper has just cut a release after #11196: floating-ui/react-popper#160 |
I confirm, it's just broken. |
Use react-popper@0.10.1 for now. |
This should be ok with react-popper@0.10.4 |
Just to clarify: the solution is to install react-popper as well as material ui? |
@timothyallan No, it's to make sure that the yarn/npm's resolution of this transitive dependency (react-popper) is OK (>= 0.10.4 || <= 0.10.1). |
cool, installing react-popper as well as material ui fixes it for us on b44 ;) |
I installed react-popper as well as material-ui and I still get the message about missing react-popper... it happens only in watch mode and only on alternate compilations!! yarn 1.6. |
I'm using react-popper 0.10.4 also :( |
Same here, happened only on alternate compilations for
|
I have the same problem with these packages and settings:
"typescript": "2.8.3",
"@material-ui/core": "^1.2.1",
"@material-ui/icons": "^1.1.0",
"react-scripts-ts": "^2.16.0",
"webpack-dev-server": "^2.11.2"
{
"compilerOptions": {
"baseUrl": ".",
"outDir": "build/dist",
"target": "es5",
"lib": ["es6", "dom"],
"sourceMap": true,
"jsx": "react",
"allowSyntheticDefaultImports": true,
"noImplicitReturns": true,
"strictNullChecks": true,
"strict": true,
"noFallthroughCasesInSwitch": true,
"rootDirs": [
"src",
"src/stories"
],
"typeRoots": [
"node_modules/@types"
],
"paths": {
"@root/*": ["./src/*"]
}
},
"include": ["src/**/*"],
"exclude": [
"node_modules",
".git"
]
} I also tried typescript 2.9.1 but couldn't fix the error. I would like to create reproducing repo. Thanks! |
In my case downgrading did the job, but I don’t recall which version was it
…On 13 Jun 2018, 13:12 +0200, Kazuya Gosho ***@***.***>, wrote:
I have the same problem with these packages and settings:
package.json
"typescript": "2.8.3",
***@***.***/core": "^1.2.1",
***@***.***/icons": "^1.1.0",
"react-scripts-ts": "^2.16.0",
"webpack-dev-server": "^2.11.2"
tsconfig.json
{
"compilerOptions": {
"baseUrl": ".",
"outDir": "build/dist",
"target": "es5",
"lib": ["es6", "dom"],
"sourceMap": true,
"jsx": "react",
"allowSyntheticDefaultImports": true,
"noImplicitReturns": true,
"strictNullChecks": true,
"strict": true,
"noFallthroughCasesInSwitch": true,
"rootDirs": [
"src",
"src/stories"
],
"typeRoots": [
***@***.***"
],
"paths": {
***@***.***/*": ["./src/*"]
}
},
"include": ["src/**/*"],
"exclude": [
"node_modules",
".git"
]
}
I also tried typescript 2.9.1 but couldn't fix the error.
I would like to create reproducing repo.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks for the comment. Which version of material-ui do you use now? |
For the time being none, I have to pause developemnt, I was using beta's
…On 13 Jun 2018, 15:43 +0200, Kazuya Gosho ***@***.***>, wrote:
@mkbctrl
Thanks for the comment. Which version of material-ui do you use now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Okay, thanks! |
Any progress with it? |
@akazakou react-popper is on it's way out of Material-UI. It should be solved with next release. I'm working on a Popper component, sharing the same concepts with Popover. |
@oliviertassinari thank you! But it anyway, maybe it helps you resolve the problem #11266 (comment) |
I ran into a variation of this. It seems somewhere in the code is says import warning from "warning"; instead of import warning from "./warning"; or something similar. Is this a know issue? I will roll back to 1.2.1 to see if that fixes it. |
But this seems react-popper related and not material-ui. Checking there also. |
@richtera We do no longer use react-popper in v4. |
In my React-Meteor app after upgrading the materiali ui to the latest version today I have noticed weird behaviour:
After downgrading to beta-41 everything goes back to normal.
The text was updated successfully, but these errors were encountered: