-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No hover color for Menu List Items in Chrome 74 #15682
Comments
Can't reproduce this with the same chrome build and Ubuntu 18.04.2 LTS. What OS are you using? Do you have the same issue in an incognito window or other browsers? |
Hi @eps1lon that's super wierd. Here's more information:
I did notice — key interaction worked. The up and down arrows changed the focused item. That might be a hint. Does material-ui do some sort of black-magic detection of whether a user is keyboard-only? |
hover and focus styles visually are different and their detection is implemented differently. Hover uses the css |
Yes, the keyboard interactions changed the style with the Experimental Web Platform features flag enabled, just the same as with it disabled. |
So it's likely not pseudo selectors per se. Just
|
Ah nice. Not sure why this media query triggers in your browser. Sounds like a bug in chrome. @oliviertassinari Though I don't understand why we need this here. If the device isn't hover capable we don't need to reset the color, no? Change was added in #7692 |
@eps1lon Mobile devices don't have a hover capability but simulate it, we need to counter the simulation. This media query shouldn't be triggered in this case. Can we ignore the problem? |
Yeah it seems like a problem with my setup — Chrome plus my desktop environment plus who-the-hell-knows what customizations I made to it. |
Why? I'm sure I asked this before but it still didn't quite click for me. |
I don't know why mobile browsers simulate the hover pseudo class. We shouldn't display the hover state after a touch interaction. It's a mobile web default behavior, not a mobile app one. |
Ah that was it. Touch will leave to element in a hover state, right? |
Yes, that's right. It's the essence of the problem. |
Yeah got it. Probably will ask again in a couple of days, though. @matthiasdailey-ccri Guess we can close this? |
Sure |
So wait what is the solution here? I'm using Chrome 84 on Ubuntu (Wayland GNOME 3.28.4) and find that none of the MUI hover effects work in Chrome due to this media query being incorrectly applied. It might be caused by something weird in my environment, but there's no way of knowing whether it will also affect end-users. |
To fix your environment? We haven't seen a lot of people in this case so far. We have seen the opposite problem too, where Samsung phones consider they have the hover capability available, which lead to residual hover effect after tap on buttons. |
Hi folks, I'm seeing a slight issue in Chrome 74, reproducible on the Menu demo page. When I mouseover a menu list item with the cursor, there is no background color change for the hovered item. Also, the focused item turns white when hovered.
A screen capture shows it best:
Steps to Reproduce 🕹
Link: https://codesandbox.io/s/9204p0pxo4
Your Environment 🌎
The text was updated successfully, but these errors were encountered: