Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Move custom theme to frame #26744

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 14, 2021

close #22112

I still want to keep #222 as background because I think this

image

is better than

image

So I move the color to frame instead. I don't think this will confuse the people because the body still contain default background color. @oliviertassinari what do you think?

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 14, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 594f225

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 15, 2021

I believe the changes are leading us to the same mistake I did initially with #22112 (2-3 years ago). I patched the docs for values I didn't like in the default theme.

I think that we should fully own the default theme: Either we say, 1. no Material Design this is not OK: #25522 (comment) and we change the default value of the theme. 2. Or we bit the bullet and follow them.

In 1. a halfway solution would be to replace #222222 with a value coming from the theme, even if it means creating a new design token. But right now, #222222 is arbitrary.

@oliviertassinari oliviertassinari changed the title [docs] move custom theme to frame [docs] Move custom theme to frame Jun 15, 2021
@siriwatknp
Copy link
Member Author

a halfway solution would be to replace #222222 with a value coming from the theme

I think we can go with theme.palette.grey[900] (#212121). looks good to me.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation design: material This is about Material Design, please involve a visual or UX designer in the process labels Jun 15, 2021
@siriwatknp siriwatknp merged commit 25a37ee into mui:next Jun 16, 2021
@siriwatknp siriwatknp mentioned this pull request Jun 23, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Sync default theme with the theme used by the documentation
3 participants