Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CssBaseline] Consider rework #38507

Open
oliviertassinari opened this issue Aug 16, 2023 · 0 comments
Open

[CssBaseline] Consider rework #38507

oliviertassinari opened this issue Aug 16, 2023 · 0 comments
Labels
breaking change component: CssBaseline The React component package: system Specific to @mui/system

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 16, 2023

This issue is extracted from #30660 to have a space to discuss the improvements we can make to this component.

CssBaseline was introduced around 2019, today browsers are different, time to consider how to best evolve it.

Ideas:

  1. https://moderncss.dev/modern-css-for-dynamic-component-based-architecture/
  2. add html { overflow-y: scroll; } to avoid layout shift when changing pages or maybe https://twitter.com/stackblitz/status/1518924375721873408 but it doesn't seem to work with position absolute elements.
  3. separate CSS resets and theme application [CssBaseline] Add colors with better constrast to <a> #38135 (comment)
  4. Remove enableColorScheme altogether, see: [material-ui] Remove enableColorScheme prop from CssBaseline #42695 or make enableColorScheme: true the default [website] Fix dark mode on brand pages #29611 (comment)
  5. button margin should be reset? I shouldn't have to spend time to do this [docs] Fix Safari button misalignment #34861.
  6. min-width: 0 everywhere: https://www.youtube.com/watch?v=cH8VbLM1958

Benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: CssBaseline The React component package: system Specific to @mui/system
Projects
None yet
Development

No branches or pull requests

2 participants