[TableBody] Why componentWillReceiveProps set only the last item selected when I deselect an item?

[akosk]

The issue:

1. I click on select all checkbox in the header of the table -> all items selected.
2. I deselect a random item.
3. All the items deselected in the table except the last one.

I found the following code in table-body.js / componentWillReceiveProps:

if (this.props.allRowsSelected && !nextProps.allRowsSelected) {
      newState.selectedRows = this.state.selectedRows.length > 0 ? [this.state.selectedRows[this.state.selectedRows.length - 1]] : [];
} else {
     newState.selectedRows = this._calculatePreselectedRows(nextProps);
}

What is the purpose of [this.state.selectedRows[this.state.selectedRows.length - 1]]?
Why should deselect all items but the last one when select all was checked before?
If I remove the true branch it works as expected: the clicked item and the select all checkbox in header becomes unchecked.

Versions

Material-UI: 0.15.0-alpha2 & 0.14.4
React: 0.14.8
Browser: Chrome (49.0.2623.112 m)

[nathanmarks]

@akosk how are you using 0.15.0-alpha2 and 0.14.4 with React 15? They aren't compatible.

[akosk]

@nathanmarks I use React 0.14.8, I corrected the version number. Sorry for my mistake.

[alan-kleiman-ingressorapido]

Repeating @akosk's question, is there a reason for [this.state.selectedRows[this.state.selectedRows.length - 1]]? Would you guys accept a PR that removes it?

[ghost]

+1

[aahan96]

@akosk: @nathanmarks is working on the 0.16.0 release, which will address many issues with the table component. Have a look at issue #2251. I think we can close this issue for now as it's being addressed in the new release