Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the styles on our own components by leveraging class names #40850

Open
jaykeerti opened this issue Jan 30, 2024 · 1 comment
Open

Reuse the styles on our own components by leveraging class names #40850

jaykeerti opened this issue Jan 30, 2024 · 1 comment
Assignees
Labels
component: SvgIcon The React component. discussion new feature New feature or request

Comments

@jaykeerti
Copy link

jaykeerti commented Jan 30, 2024

Summary

There are many situations where we could use inbuilt mui classes with our own components to style them to look like mui components. Now the feature is dropped as the classes are generated dynamically and they need to be overridden

Examples

Based on the below code i am calling the MuiSvgIcon-root class inside the StepIcon component to use its properties but it shows up as blank.

className={clsx("MuiSvgIcon-root MuiStepIcon-root")}

Demo

Motivation

This would be really helpful to create lookalike components without overriding them

Search keywords: className,

@jaykeerti jaykeerti added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 30, 2024
@zannager zannager added the component: SvgIcon The React component. label Jan 30, 2024
@siriwatknp siriwatknp added new feature New feature or request discussion and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 1, 2024
@siriwatknp
Copy link
Member

siriwatknp commented Feb 1, 2024

I'd considered this as a new feature for the current and future style engine that we are working on but it's not a conclusion that we will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: SvgIcon The React component. discussion new feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants