[React] Fix props forwarding warning for v15.2.0

[oliviertassinari]

Problem description

React is about to release a new version of React: v15.2.0. They are introducting a new warning.
For more details, react-bootstrap/react-bootstrap#1994 is a good place to start.

We are already aware of this issue (props forwarding down the tree) and we have tried to address it. However, I'm pretty sure it's not solve at 100% yet.

[nathanmarks]

@oliviertassinari Oh my, this is going to be fun 😄, 73 warnings in the documentation.

[oliviertassinari]

We should fix this issue quickly, v15.2.0 has already been released https://github.com/facebook/react/releases/tag/v15.2.0.
I'm gonna work on it this week-end.

[flaccid]

I did think that I was doing my own elements and styles wrong, but then after updating my code the only warnings left were pertaining to the material-ui components I was using. Look forward to a fix for all those!

[nathanmarks]

@flaccid should be finished tomorrow

[OshotOkill]

My application is blowed up after having updated to 15.2. Looking forward to some fixes.

[oliviertassinari]

Most of the warnings should be fixed on the master branch now.
We need the feedbacks of the community to fix the remaining one.
I'm closing this issue. @callemall/material-ui Would be good to do a release soon.

[alitaheri]

Would be good to do a release soon.

0.15.2 is ready to be released. I'll include these changes and update the notes soon.

[nathanmarks]

@alitaheri I have one more fix that needs doing for 0.15.2. Stepper animation in Safari.

[Intey]

After update to master from npm latest version, still get transitionAppearTimeout .
Full message:

warning.js:44 Warning: Unknown prop `transitionAppearTimeout` on <div> tag. 
Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by ReactTransitionGroup)
    in ReactTransitionGroup (created by DialogInline)
    in div (created by DialogInline)
    in DialogInline
    in MuiThemeProvider

[oliviertassinari]

After update to master from npm latest version, still get transitionAppearTimeout

@Intey That's an issue with React. Wait for them to release a fix. facebook/react#7163.

[alexhancock]

Any word on when these changes might land in a new release?

[alitaheri]

@alexhancock Soon.....#4572

[alexhancock]

Cool - thanks!

[lnmunhoz]

This version is breaking with the package inline-style-prefixer@v2.0.1

[Jpunt]

I'm still getting a bunch unknown-props-warnings in 15.0.2. Am I alone in this?

[oliviertassinari]

@Jpunt A couple more have been fixed since the release. Could you try with the master branch?

[Jpunt]

@oliviertassinari I'd like to, but when I install the package from its git-url I get the following error:

UNMET DEPENDENCY material-ui@git://github.com/callemall/material-ui.git#master

How should I install this?

[GuillaumeCisco]

I encounter an issue with MenuItem:

React.dll.js:19164 Warning: Unknown prop `onRequestClose` on <span> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in span (created by EnhancedButton)
    in EnhancedButton (created by ListItem)
    in div (created by ListItem)
    in ListItem (created by MenuItem)
    in MenuItem (created by Menu)
    in div (created by List)
    in List (created by Menu)
    in div (created by Menu)
    in ClickAwayListener (created by Menu)
    in Menu (created by MenuItem)
    in div (created by PopoverDefaultAnimation)
    in div (created by PopoverDefaultAnimation)
    in div (created by Paper)
    in Paper (created by PopoverDefaultAnimation)
    in PopoverDefaultAnimation
    in MuiThemeProvider

Anyway to fix it?
Master branch is no help here.
Thank you,

[oliviertassinari]

@GuillaumeCisco As far as I have looked at it. This props is most likely provided on your side. Somewhere it has no effect.

[GuillaumeCisco]

@oliviertassinari, are you referring to the React.dll.js file? Cuz I use the webpack dll plugin.
Anyway, I didn't write onRequestClose in my business code, it comes from redux-form.

[nathanmarks]

@GuillaumeCisco material-ui isn't responsible for cleaning all invalid props

[GuillaumeCisco]

Oh yeah... Oups... Wrong repo... ^^"
Sorry for misconception...

[GuillaumeCisco]

In fact... It's not about redux-form. It's due to material-ui. The code is present in version 15.0.2
How to test the last changes from the master branch?
Every time I want to download the repository via npm, I get an material-ui-build folder with uncompressed source, and cannot use it in my application.

[hoolymama]

I'm seeing these deprecation warnings related to the List component.

EDIT: Apologies, I've just seen a separate issue for it here #4854

You are manually calling a React.PropTypes validation function for the insetSubheader prop on List. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

You are manually calling a React.PropTypes validation function for the subheader prop on List. This is deprecated.....

You are manually calling a React.PropTypes validation function for the subheaderStyle prop on List. This is deprecated.....

[SerendpityZOEY]

Hi @oliviertassinari , I'm still having the same problem with unknown props and here's my code:

                <List>
                    <ListItem
                        key={1}
                        primaryText={
                            "Cluster: "+this.props.pattern.pattern.cluster_key_sni
                        }
                        href={'/cluster'}
                        target="_blank"
                    />
                    <ListItem
                        key={2}
                        primaryText={
                            "Frequency: "+this.props.pattern.pattern.frequency_sni
                        }
                    />
                    <ListItem
                        key={3}
                        primaryText={
                            "List of matching groums: "
                        }
                        href={'/groum'}
                        target="_blank"
                        nestedItems={[
                            <pre style={{marginLeft:16,marginRight:16}} key={1}><code dangerouslySetInnerHTML={{__html: this.props.pattern.pattern.groum_keys_t}}></code></pre>
                        ]}
                    />
                </List>

The front-end looks good but it has a warning of:Unknown prop nestedLevel on

 tag.

Do you have any idea of how to fix this? Thanks!