-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React] Fix props forwarding warning for v15.2.0 #4594
Comments
@oliviertassinari Oh my, this is going to be fun 😄, 73 warnings in the documentation. |
We should fix this issue quickly, v15.2.0 has already been released https://github.com/facebook/react/releases/tag/v15.2.0. |
I did think that I was doing my own elements and styles wrong, but then after updating my code the only warnings left were pertaining to the material-ui components I was using. Look forward to a fix for all those! |
@flaccid should be finished tomorrow |
Most of the warnings should be fixed on the master branch now. |
|
@alitaheri I have one more fix that needs doing for |
After update to
|
@Intey That's an issue with React. Wait for them to release a fix. facebook/react#7163. |
Any word on when these changes might land in a new release? |
@alexhancock Soon.....#4572 |
Cool - thanks! |
This version is breaking with the package inline-style-prefixer@v2.0.1 |
I'm still getting a bunch unknown-props-warnings in 15.0.2. Am I alone in this? |
@Jpunt A couple more have been fixed since the release. Could you try with the master branch? |
@oliviertassinari I'd like to, but when I install the package from its git-url I get the following error:
How should I install this? |
I encounter an issue with
Anyway to fix it? |
@GuillaumeCisco As far as I have looked at it. This props is most likely provided on your side. Somewhere it has no effect. |
@oliviertassinari, are you referring to the React.dll.js file? Cuz I use the webpack dll plugin. |
@GuillaumeCisco material-ui isn't responsible for cleaning all invalid props |
Oh yeah... Oups... Wrong repo... ^^" |
In fact... It's not about |
I'm seeing these deprecation warnings related to the List component. EDIT: Apologies, I've just seen a separate issue for it here #4854
|
Hi @oliviertassinari , I'm still having the same problem with unknown props and here's my code: <List>
<ListItem
key={1}
primaryText={
"Cluster: "+this.props.pattern.pattern.cluster_key_sni
}
href={'/cluster'}
target="_blank"
/>
<ListItem
key={2}
primaryText={
"Frequency: "+this.props.pattern.pattern.frequency_sni
}
/>
<ListItem
key={3}
primaryText={
"List of matching groums: "
}
href={'/groum'}
target="_blank"
nestedItems={[
<pre style={{marginLeft:16,marginRight:16}} key={1}><code dangerouslySetInnerHTML={{__html: this.props.pattern.pattern.groum_keys_t}}></code></pre>
]}
/>
</List> The front-end looks good but it has a warning of:Unknown prop tag. |
Problem description
React is about to release a new version of React: v15.2.0. They are introducting a new warning.
For more details, react-bootstrap/react-bootstrap#1994 is a good place to start.
We are already aware of this issue (props forwarding down the tree) and we have tried to address it. However, I'm pretty sure it's not solve at 100% yet.
The text was updated successfully, but these errors were encountered: