Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pull to refresh" issue with ListItem #7992

Closed
orck-adrouin opened this issue Aug 31, 2017 · 3 comments
Closed

"Pull to refresh" issue with ListItem #7992

orck-adrouin opened this issue Aug 31, 2017 · 3 comments
Labels
component: list This is the name of the generic UI component, not the React module!

Comments

@orck-adrouin
Copy link

Problem description

I am integrating a "pull to refresh" feature in a web app using this library: https://github.com/yusukeshibata/react-pullrefresh . This library is a simple wrapper around the touch events (start, move, end) and I used it in a previous project without any issues.

The issue I have is Material-UI components seems to be stop the propagation of touch events, meaning if you started pulling on a Material-UI component, such as a ListItem, the touch start event is never send to the "pull to refresh" library.

It looks like this is fixed in v1-beta (#6311) but I would like to know if there is a workaround I can use until v1 is officially released/stable.

Steps to reproduce

<List onTouchStart={() => console.warn("starting to touch")}>
   <ListItem primaryText="Some text" />
</List>

Versions

  • Material-UI: 0.19
  • React: 15.5
  • Browser: Desktop Chrome using touch device dev tool, iOS Safari
@oliviertassinari
Copy link
Member

I would like to know if there is a workaround I can use until v1 is officially released/stable.

Not I'm aware of. It's unlikely we will fix the issue on the master branch given the potentiel breaking change behavior of removing the prevent default could have. I can't see a better path going forward than using the v1-beta branch. Sorry. I'm closing.

@orck-adrouin
Copy link
Author

Is it possible to use the 0.19 branch and the v1-beta branch side by side?

@oliviertassinari
Copy link
Member

Yes, you can. #7195 might help.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: list This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants